David Glick wrote:
PLIP 126 (Link type should automatically redirect when accessed directly) has been implemented. You can get the review buildout from:
http://svn.plone.org/svn/plone/review/plip126-link-redirects

I'm going to paste the contents of http://svn.plone.org/svn/plone/review/plip126-link-redirects/PLIP_126_README.txt here for ease of any discussion...


Review bundle for PLIP 126: Link type should automatically redirect when accessed directly
==========================================================================================

As Danny triggered some discussion already I'll add my comments
(which I don't consider finished yet - that's why I didn't post them
up to now). It's been a while that I did this and I might not be
up-to-date with everything.


Raphael's comments
==================
(as of 2009-01-16)

* on a new site the link type and the configuration options work
as advertised

* the migration worked for me on a randomly picked site of mine.

* I don't understand why 'link_view' isn't made available as an alternative
view on instance base still. That could easily be achieved by leaving it
in the "Available view methods" property of the FTI. That way one
could control this behavior on instance base even.
At the very least this should be properly documented.

* running the tests for CMFPlone I get 3 failures but they are all
unrelated to the changes in question here (UnicodeSplitter, Latin1 processing,
and migration related stuff)

* Running the tests of plone.app.controlpanel on a vanilla checkout of the
plip buildout generated one failure for me (Ubuntu/packaged uncustomized
Python 2.4):

...

 Set up Products.PloneTestCase.layer.PloneSite in 18.665 seconds.
 Running:
.................................................................................................................

Failure in test /home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt
Failed doctest test for types.txt
File "/home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt", line 0

----------------------------------------------------------------------
File "/home/ritz/buildouts/reviewing/plip126-link-redirects/src/plone.app.controlpanel/plone/app/controlpanel/tests/types.txt", line 75, in types.txt
Failed example:
   self.browser.contents
Expected:
   '...Globally addable...
   ...Allow comments...
   ...Visible in searches...
   ...<input id="redirect_links"...
   ...type="checkbox"...
   ...name="redirect_links:boolean"...
   ...checked="checked">...
   ...<label for="redirect_links">...
   ...Redirect links to remote url...'
Got:
'\n \n\n\n<!DOCTYPE html PUBLIC\n "-//W3C//DTD XHTML 1.0 Transitional//EN"\n "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd";>\n\n\n<html xmlns="http://www.w3.org/1999/xhtml"; xml:lang="en"\n lang="en">\n\n
(truncated by me here)

Guess it's because it expects ...Redirect links to remote url...' but
it gets ...Redirect immediately to link target...

Potentially more to follow

Raphael



_______________________________________________
Framework-Team mailing list
Framework-Team@lists.plone.org
http://lists.plone.org/mailman/listinfo/framework-team

Reply via email to