#9352: Improved search results ----------------------------+----------------------------------------------- Reporter: laurenskling | Owner: spliter Type: PLIP | Status: assigned Priority: major | Milestone: 4.2 Component: Infrastructure | Keywords: search ----------------------------+-----------------------------------------------
Comment(by rossp): Replying to [comment:56 davisagli]: > Replying to [comment:55 rossp]: > > (In [46338]) Add a review note about reusing plone.app.querystring. Refs #9352. > > > > It occurrs to me that this PLIP could have and probably should have > > re-used the plone.app.querystring package created for > > plone.app.collection which provides their AJAX search query > > building. > > IMHO a javascript-based query builder like that is appropriate for a site admin function like editing a collection, but not for an end-user function like buildout a search, which should still function with javascript disabled. I wasn't necessarily suggesting we expose the entire dynamic query building support of the package, but re-use the common bits. There end up being a lot of edge case bugs with dynamic stuff like this, and it's a shame to fix the bugs in two places. Especially given that p.a.search is still so buggy. -- Ticket URL: <http://dev.plone.org/plone/ticket/9352#comment:116> Plone <http://plone.org> Plone Enterprise Content Management System _______________________________________________ PLIP-Advisories mailing list plip-advisor...@lists.plone.org https://lists.plone.org/mailman/listinfo/plone-plip-advisories