Hi,

FreeAMP 2.1 rc2 does not build the GUI plugin on BSD Unix systems.
Line 505 of configure.in contains the error which is causing the
problem.

Line 505 is 
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/freeamp.ui" dnl #MakeTheme"

(context is)
if test "$have_gtk" = "true"; then
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/musicbrowser.ui"
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/freeamp.ui" dnl #MakeTheme"
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/download.ui"
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/winamp.ftf"
  OSDEPPLUGINS="$OSDEPPLUGINS plugins/kjofol.ftf"


autoconf parses this OK, but generates an invalid configure file.
(with two OSDEPPLUGINS=xxxx entries on the same line)
When configure is run, it ignores and skips over the freeamp.ui line
so the GUI does not go into Makefile-plugin and is not built


The Fix
-------
Simply remove the comment (the dnl) or move it to a new line.


My patch is

*** configure.in.orig   Sun Oct  8 14:22:09 2000
--- configure.in        Sun Oct  8 14:22:41 2000
*************** fi
*** 502,508 ****
  
  if test "$have_gtk" = "true"; then
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/musicbrowser.ui"
!   OSDEPPLUGINS="$OSDEPPLUGINS plugins/freeamp.ui" dnl #MakeTheme"
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/download.ui"
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/winamp.ftf"
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/kjofol.ftf"
--- 502,509 ----
  
  if test "$have_gtk" = "true"; then
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/musicbrowser.ui"
!   OSDEPPLUGINS="$OSDEPPLUGINS plugins/freeamp.ui"
! dnl if you have freeamp.ui, you may also want to build MakeTheme
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/download.ui"
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/winamp.ftf"
    OSDEPPLUGINS="$OSDEPPLUGINS plugins/kjofol.ftf"



With this fix in place, I've got the full GTK GUI working on
FreeBSD.

Please can someone commit this patch.
Thanks
Roger
--
Roger Hardiman
FreeBSD Project
[EMAIL PROTECTED]
_______________________________________________
[EMAIL PROTECTED]
http://www.freeamp.org/mailman/listinfo/freeamp-dev

Reply via email to