>Number: 188010
>Category: amd64
>Synopsis: madt_parse_nmi() checking incorrect flag
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-amd64
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Thu Mar 27 05:40:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator: Takuya ASADA
>Release: -CURRENT
>Organization:
Cloudius Systems
>Environment:
>Description:
madt_parse_nmi() checks ACPI_MADT_TRIGGER_CONFORMS before calling
ioapic_set_polarity(), but it should check ACPI_MADT_POLARITY_CONFORMS instead.
I suppose this is typo.
>How-To-Repeat:
I haven't get any problem from this bug
>Fix:
Patch attached with submission follows:
diff --git a/sys/x86/acpica/madt.c b/sys/x86/acpica/madt.c
index 9dfb77f..3e8aee5 100644
--- a/sys/x86/acpica/madt.c
+++ b/sys/x86/acpica/madt.c
@@ -492,7 +492,7 @@ madt_parse_nmi(ACPI_MADT_NMI_SOURCE *nmi)
if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
ioapic_set_triggermode(ioapic, pin,
interrupt_trigger(nmi->IntiFlags, 0));
- if (!(nmi->IntiFlags & ACPI_MADT_TRIGGER_CONFORMS))
+ if (!(nmi->IntiFlags & ACPI_MADT_POLARITY_CONFORMS))
ioapic_set_polarity(ioapic, pin,
interrupt_polarity(nmi->IntiFlags, 0));
}
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-amd64
To unsubscribe, send any mail to "[email protected]"
