>Number: 169976
>Category: kern
>Synopsis: Patch to make scsi_da use sysctl values where appropriate
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Wed Jul 18 16:10:03 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Steven Hartland
>Release: 8.3-RELEASE
>Organization:
Multiplay
>Environment:
FreeBSD build 8.3-RELEASE-p3 FreeBSD 8.3-RELEASE-p3 #3: Tue Jul 3 13:16:31 UTC
2012 root@build:/usr/obj/usr/src/sys/MULTIPLAY amd64
>Description:
Changed scsi_da device requests to use the sysctl tunable value for retry_count
and da_default_timeout where their current hardcoded values matched the current
default value for said tunables.
>How-To-Repeat:
N/A
>Fix:
Apply the attached patch
Patch attached with submission follows:
Changed scsi_da device requests to use the sysctl tunable value for retry_count
and da_default_timeout where their current hardcoded values matched the current
default value for said tunables.
--- sys/cam/scsi/scsi_da.c.orig2 2012-07-18 15:58:29.821055604 +0000
+++ sys/cam/scsi/scsi_da.c 2012-07-18 16:00:39.591128067 +0000
@@ -1955,7 +1955,7 @@
}
csio = &start_ccb->csio;
scsi_read_capacity(csio,
- /*retries*/4,
+ /*retries*/da_retry_count,
dadone,
MSG_SIMPLE_Q_TAG,
rcap,
@@ -1980,7 +1980,7 @@
}
csio = &start_ccb->csio;
scsi_read_capacity_16(csio,
- /*retries*/ 4,
+ /*retries*/ da_retry_count,
/*cbfcnp*/ dadone,
/*tag_action*/ MSG_SIMPLE_Q_TAG,
/*lba*/ 0,
@@ -1989,7 +1989,7 @@
/*rcap_buf*/ (uint8_t *)rcaplong,
/*rcap_buf_len*/ sizeof(*rcaplong),
/*sense_len*/ SSD_FULL_SIZE,
- /*timeout*/ 60000);
+ /*timeout*/ da_default_timeout * 1000);
start_ccb->ccb_h.ccb_bp = NULL;
start_ccb->ccb_h.ccb_state = DA_CCB_PROBE2;
xpt_action(start_ccb);
>Release-Note:
>Audit-Trail:
>Unformatted:
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[email protected]"
