https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=206585
Bug ID: 206585
Summary: hpt_set_info possible buffer overflow
Product: Base System
Version: 11.0-CURRENT
Hardware: Any
OS: Any
Status: New
Severity: Affects Only Me
Priority: ---
Component: kern
Assignee: [email protected]
Reporter: [email protected]
In `hpt_status` -> `hpt_set_info`, `nOutBufferSize` and `nInBufferSize` are
checked at the same time, but not individually:
if (piop->nInBufferSize+piop->nOutBufferSize > PAGE_SIZE) {
KdPrintE(("User buffer too large\n"));
return -EINVAL;
}
Before performing a kernel allocation:
ke_area = malloc(piop->nInBufferSize+piop->nOutBufferSize, M_DEVBUF, M_NOWAIT);
However, the sizes are later used individually for some copies:
if (piop->nInBufferSize)
copyin((void*)(ULONG_PTR)piop->lpInBuffer, ke_area,
piop->nInBufferSize);
...
if (piop->nOutBufferSize)
copyout(ke_area + piop->nInBufferSize,
(void*)(ULONG_PTR)piop->lpOutBuffer, piop->nOutBufferSize);
It might be possible for `nInBufferSize`, or `outBufferSize`, or both, to be
large enough for `piop->nInBufferSize+piop->nOutBufferSize` to overflow and be
less than `PAGE_SIZE`.
In this situation the copy calls would result in a heap overflow.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
[email protected] mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "[email protected]"
