https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216265
Bug ID: 216265
Summary: [patch] [mppc] invalid KASSERT prevent building kernel
with NETGRAPH_MPPC_COMPRESSION and INVARIANTS
Product: Base System
Version: 11.0-STABLE
Hardware: Any
OS: Any
Status: New
Keywords: patch
Severity: Affects Some People
Priority: ---
Component: kern
Assignee: freebsd-bugs@FreeBSD.org
Reporter: po...@grosbein.net
Keywords: patch
Created attachment 179079
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179079&action=edit
unbreak debugging kernel build
Since 11.0-RELEASE, FreeBSD includes implementation of MMPC.
Build of kernel configuration containing both of NETGRAPH_MPPC_COMPRESSION and
INVARIANTS fails:
--- ng_mppc.o ---
/home/src/sys/netgraph/ng_mppc.c:546:18: error: use of undeclared identifier
'MPPC_INVALID'
KASSERT(rtn != MPPC_INVALID, ("%s: invalid", __func__));
According to http://media.digikey.com/pdf/Data%20Sheets/EXAR%20PDFs/MPPC-C.pdf
return value MPPC_INVALID (zero) for "rtn" variable was supposed to denote
invalid values for arguments srcCnt, dstCnt or flags passed to function
MPPC_Compress(). Our implementation in sys/net/mppcc.c does not perform such
validity checks and never returns zero value, so this KASSERT should be
removed.
Also, /* XXX NETGRAPH_MPPC_COMPRESSION isn't functional yet */ comment in the
same file and some others are not valid anymore. This includes sys/conf/NOTES
and sys/conf/options.
Attached patch fixes this.
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
