https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210537
Eugene Grosbein <eu...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |In Progress
--- Comment #16 from Eugene Grosbein <eu...@freebsd.org> ---
(In reply to Mikhail T. from comment #15)
It still does not respect WITHOUT_FILE.
And if such code uses openssl, it should depend on WITHOUT_OPENSSL too.
However, our libc actually has b64_ntop() function for base64 encoding provided
with <resolv.h> header and you can get example of its usage from
src/usr.bin/uuencode/uuencode.c
"usage" message mistakenly shows "-m" instead of "-M".
Added #include's should be sorted by name of header.
sizeof(char) is 1 by definition of C programming language (see
http://chimera.roma1.infn.it/SP/COMMON/iso-iec-9899-1990.pdf section 6.5.3.4
paragraph 4), so you need not use bufsize*sizeof(char).
With MAGIC_MIME flag to magic_open() you request both of MIME type and encoding
but then skip MIME type with strstr() looking for encoding only. Wouldn't it
better to use MAGIC_MIME_ENCODING instead of MAGIC_MIME and directly compare
result with "charset=binary"?
Otherwise, looks good, thanks!
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-bugs@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-bugs
To unsubscribe, send any mail to "freebsd-bugs-unsubscr...@freebsd.org"
