https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210537
--- Comment #26 from Eugene Grosbein <[email protected]> --- (In reply to Mikhail Teterin from comment #25) The patch still has multiple issues: - cron.8 part is corrupted, please check it out carefully; - the change for usage() function still has the bug I already noted: it adds -m instead of right -M; - the change still does not respect WITHOUT_FILE build option that is required for CDDL-clean build of the system. Also, while increasing WARNS is good intention, such style changes should not be mixed with functional additions like yours. Please split the change in two, one for your own code and second for a patch touching other parts of code just fixing warnings. Among other things, it will make code review easier. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ [email protected] mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-bugs To unsubscribe, send any mail to "[email protected]"
