https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=261434

--- Comment #12 from Ivan Rozhuk <[email protected]> ---
(In reply to Alan Somers from comment #11)

> Looking at the code you sent, sshfs_utimens is ignoring the tv_nsec field, 
> which is clearly a bug.

I agree that libfuse+sshfs code is not clean, but sshfs MUST sent atime+mtime
in one message.

https://datatracker.ietf.org/doc/html/draft-ietf-secsh-filexfer-02
>    The `atime' and `mtime' contain the access and modification times of
>    the files, respectively.  They are represented as seconds from Jan 1,
>    1970 in UTC.

There is no place to nsec and magic values.


> This is a bug in sshfs, and you should report it upstream.

libfuse does not call utimens() in case UTIME_OMIT, as far I understand.
I have no plans to report it.


> Did your friend use "-o strictatime"?

No, just -o atime.
atime is updated in his tests, mtime is not.


> Always sending mtime along with atime would be exactly the wrong thing for 
> the kernel to do.  Only sending atime is what it's supposed to do.

Another way is to get mtime/atime some where inside sshfs, probably sending
additional requests, witch I do not like.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to