https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275006
Bug ID: 275006
Summary: libpfctl: c2e7cbe0edb backport broke label set on rule
Product: Base System
Version: 13.2-STABLE
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: bin
Assignee: [email protected]
Reporter: [email protected]
Created attachment 246228
--> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=246228&action=edit
fix the typo
Hi,
If you compare the change from from main and stable/13 you can see that main
uses "nvl" and stable/13 has "nlvr" for nvlist_append_string_array() but the
backport changes it to "nlv". I'm not even sure if this was a clean
cherry-pick or manual conflict resolution, but it isn't working in either case.
This code was supposed to apply to pfctl_add_eth_rule() but instead applied to
pfctl_add_rule() for otherwise interesting reasons. Since pfctl_add_eth_rule()
uses "nvl" and pfctl_add_rule() uses "nvlr" but also has "nvl" this compiled
fine but still broke the label set.
The bit that is most intriguing is that pfctl_add_eth_rule() doesn't even exist
on stable/13 and that this wasn't caught by the existing tests.
A patch is attached.
Cheers,
Franco
--
You are receiving this mail because:
You are the assignee for the bug.
