https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289748
Andriy Gapon <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|New |Open CC| |[email protected], | |[email protected] --- Comment #8 from Andriy Gapon <[email protected]> --- Regarding potential code improvements. It seems that ahci_pci code uses some low level accesses for MSI-X information. Those probably originate from early days of MSI-X support in FreeBSD. I think that, e.g., a function like ahci_pci_read_msix_bars() could be replaced with or re-implemented in terms of standard pci bus methods like pci_msix_table_bar. But that's a minor point. I think that a failure to allocate one of those BARs should not translate to a failure to attach. It should simply disable MSI-X for the device and proceed with other interrupt modes. BTW, I wonder if pci_msix_table_bar_method and pci_msix_pba_bar_method, or even pci_read_cap before them, could do some verification of the MSI-X BARs. -- You are receiving this mail because: You are the assignee for the bug.
