https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=291374

Jose Luis Duran <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
             Status|New                         |Open

--- Comment #4 from Jose Luis Duran <[email protected]> ---
(In reply to Simon Wollwage from comment #3)

Yes, thank you!  That patch could work.

You should be able to just make libc (make -C lib/libc), however, that never
works for me, so I always buildworld:

1. cd /usr/src       (or to the directory containing your source tree).
2. make -j $(nproc) buildworld
3. make -j $(nproc) installworld

Also, since there are no tests for getopt(3), our tests are all the other tests
that use getopt(3).  To test the entire suite I've been using bricoler
(https://github.com/markjdb/bricoler).  I realize that for this particular bug,
the barrier for testing might be particularly high.

There are a few style(9) changes, but overall that seems to fix this bug.  If
you're up for it, open a GiHub Pull Request OR a review on Phabricator
(https://reviews.freebsd.org) (I'm sure these instructions are somewhere, but I
can't seem to find them).

Finally, given the original file was obtained from NetBSD, it is always a good
practice to also file a bug with them, letting them know this bug report and
the fix.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to