https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292130
--- Comment #4 from Ed Maste <[email protected]> --- > Thanks Ed, that clarifies a little, but that wasn't the confusing bit for me. Yeah, I didn't think this was sufficient and so didn't close the PR, just a realization that at the very least the description of NO_CLEAN in Makefile.inc1 should indicate that by default it doesn't do anything / isn't needed. I'm trying to find a good way to handle this. I wanted to remove NO_CLEAN / NOCLEAN but had pushback at the time; maybe folks would be OK with it now. The message was intended to encourage people to use WITH_CLEAN or WITHOUT_CLEAN instead of setting -DNO_CLEAN on the command line, to avoid a surprise if support for NO_CLEAN gets removed. If we're certain we're never going to change the default we can just remove the message and the handling for NO_CLEAN; then, setting -DNO_CLEAN would do nothing just as any other unhandled option like "-DNO_BUGS". You can in fact set WITHOUT_CLEAN in src.conf, it's just not needed as it's the default. This is true for all of the WITH_/WITHOUT_ knobs. There are some knobs that might change defaults on main vs release branches (e.g. WITH_MALLOC_PRODUCTION) so there are situations where users could leave the setting in place. -- You are receiving this mail because: You are the assignee for the bug.
