https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=295103
--- Comment #5 from Olivier Cochard <[email protected]> --- Some question for Benoit regarding the patch: 1. Debug code left in tpmtis_attach(): the viddid = RD4(...) read and device_printf(dev, "viddid=%#x\n", viddid) look like leftover debugging, do you confirm ? 2. Style(9) issues in those debug lines: missing spaces around = and after , (viddid=RD4(sc,TPM_DID_VID)). 3. Comment wording: /* Add this line to support ST33KTPM2X32CKE3 */ should describe what the code does, not that it was added, e.g. /* Return device to ready state; required by ST33KTPM2X32CKE3. */ 4. The actual fix uses WR4/bus_barrier while the rest of the file uses TPM_WRITE_4/TPM_WRITE_BARRIER, could it match the surrounding style ? -- You are receiving this mail because: You are the assignee for the bug.
