Matthew Dillon writes:
> :On a somewhat similar note, what do you think about converting a lot
> :of the NFS macros to functions, yes i know it will be difficult, but
> :there is so much forced inlining it just seems like it would reduce
> :the codesize signifigantly and play nicer with the CPU cache.
> :
> :It would also make the code a lot more readable.
> :
> :Worthwhile exercise?
> :
> :-Alfred Perlstein - [[EMAIL PROTECTED]|[EMAIL PROTECTED]]
>
> Well, the issue with converting many of the macros to inline functions
> is with the embedded goto's and references to variables defined outside
> the macros. Converting them to functions would basically require
> rewriting a huge chunk of NFS code.
>
> This is one of those "If it ain't broke, don't fix it" scenarios, I'm
> afraid. It would take too long to redo it all (and remember, I'm the
> guy who usually *likes* rewriting code!). As much as I would like to
> make NFS more readable, it just isn't worth the effort.
It still might be a "worthwhile exercise", if your goal is simply
to increase your understanding of the NFS code.
-Archie
___________________________________________________________________________
Archie Cobbs * Whistle Communications, Inc. * http://www.whistle.com
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
