Re: egcs -O breaks ping.c:in_cksum()

[Sheldon Hearn]

On Tue, 16 Nov 1999 09:45:36 +0100, Pierre Beyssac wrote:

> > -   volatile u_short answer = 0;
> > +   union {
> > +       u_int16_t us;
> > +       u_int8_t  uc[2];
> > +   } answer;

> Uh, which one(s) do you mean exactly? The 4-space indented union
> (I just followed style(9))

The word ``union'' doesn't appear in style(9) and a 1 tab indent is used
consistently in the examples of structs.  Use 1 tab.

> or the double space before uc[2] (it was just to align us and uc
> vertically)?

Use tabs for that as well.

Look at the rest of ping.c, and you'll see that 4-space indents aren't
used except to prevent line-wrap in one weird case of a switch block and
for run-over lines.

Ciao,
Sheldon.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message