On Wed, Dec 14, 2011 at 7:27 PM, Max Khon <f...@samodelkin.net> wrote:
> Garrett,
> On Thu, Dec 1, 2011 at 2:15 PM, Garrett Cooper <yaneg...@gmail.com> wrote:
>> I've attached a patch that makes make do what I would like it to do;
>> there are some other items that require cleanup to achieve the `argv0'
>> prefixing that's available in gmake, but this is good enough for a
>> meaningful traceback when things fail. Pastebin available here, just
>> in case the mailing list eats my patch: http://pastebin.com/dFqcDRfv
>> $ cat ~/Makefile
>> all:
>>        cd $$HOME/foo; ${MAKE} $@
>> $ cat ~/foo/Makefile
>> all: foo bar barf yadda
>> foo bar yadda:
>>        @true
>> baz:
>>        @false
>> barf: baz
>> $ $PWD/make -j4 -f ~/Makefile all
>> cd $HOME/foo; /usr/src/usr.bin/make/make all
>> *** [baz] Error code 1
>> 1 error
>> *** [all] Error code 2
>> 1 error
>> $
>> If someone would please, PLEASE commit this.. I will give you beer, or
>> wine, or a copy of Skyrim, or a few months subscription to WoW, or
>> something else of value to you that we could negotiate :)... I'm quite
>> frankly tired of having to playing guessing games fishing through logs
>> trying to determine build errors on FreeBSD if and when they do occur
>> with pmake, and I'm sure that a number of developers and build/release
>> engineers out there are in the same boat as I am.
> Can you explain why did you remove MESSAGE() invocations in your patch?
> Other than that the patch looks good to me.

    I thought that printing out MESSAGE and the more informative
*printf was kind of redundant.

PS A sidenote why I bypassed MESSAGE(..): if I used the macro, make
would segfault as MESSAGE depends on targFmt and targPrefix being set
to something sane (they both default to NULL -- one explicitly, the
other implicitly because it's in the .BSS). These vars are only set in
one section of code, but I took the easy route out to avoid
accidentally breaking other code paths and because what I did in the
previously attached patch was simple to implement and test.
freebsd-current@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to