On Mon, Sep 24, 2012 at 04:55:20PM +0100, Steven Hartland wrote: > ----- Original Message ----- > From: "Bob Bishop" <r...@gid.co.uk> > To: "Pawel Jakub Dawidek" <p...@freebsd.org> > Cc: <freebsd-current@freebsd.org>; <freebsd...@freebsd.org>; "Steven > Hartland" <kill...@multiplay.co.uk> > Sent: Monday, September 24, 2012 3:17 PM > Subject: Re: ZFS TRIM support committed to HEAD. > > > > Hi, > > > > On 23 Sep 2012, at 23:25, Pawel Jakub Dawidek wrote: > > > >> I have a patch against stable/8, but not stable/9: > >> > >> http://people.freebsd.org/~pjd/patches/zfstrim8.patch > > > > Running with that in an otherwise 8-STABLE GENERIC amd64 kernel, I'm > > getting: > > > > kstat.zfs.misc.zio_trim.zio_trim_bytes: 0 > > kstat.zfs.misc.zio_trim.zio_trim_success: 0 > > kstat.zfs.misc.zio_trim.zio_trim_unsupported: 0 > > kstat.zfs.misc.zio_trim.zio_trim_failed: 2742 > > > > which doesn't look like it's working. The SSDs are: > > > > ad4: 114473MB <ADATA SSD S510 120GB 3.3.2> at ata2-master UDMA100 SATA 3Gb/s > > ad6: 114473MB <ADATA SSD S510 120GB 3.3.2> at ata3-master UDMA100 SATA 3Gb/s > > > > Any suggestions? Thanks > > Don't think ad supports TRIM, switch to ada (ahci) and you should be good. > > Although I'm surprised your seeing that many reported failures as it should > have disabled it on a pool level after the first few failures. > > Is it still increasing?
Note that 'failed' count is increasing, not the 'unsupported' count. We disable TRIM automatically if we get EOPNOTSUPP and ATA is returning some other error(s). -- Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://tupytaj.pl
pgpNdLRO6o97M.pgp
Description: PGP signature