On Thu, Mar 14, 2013 at 08:28:25AM +0100, Dirk Engling wrote:
> Hash: SHA1
> On 13.03.13 23:08, Pawel Jakub Dawidek wrote:
> > I think I considered something similar at first, but the change I 
> > proposed was optimal, IMHO at the cost of producing pretty large
> > diff, because of indentation change. But to be sure, can you send a
> > patch of your proposed change?
> http://erdgeist.org/arts/software/Code/pidfile.c.diff

Right. Your patch assumes EWOULDBLOCK is equal to EAGAIN, which is true
on FreeBSD, but is not portable. Also in case pidptr is NULL you compare
errno three times instead of just one (not a big deal of course, just
something that could be done a bit more optimal:)).

Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://tupytaj.pl

Attachment: pgpdpnLR5mSxt.pgp
Description: PGP signature

Reply via email to