These caught my eye today, and the checks strewn about sys/dev/drm2/radeon seem completely bogus to me, but I don't have the h/w to test it at the moment.
/usr/src/sys/modules/drm2/radeonkms/../../../dev/drm2/radeon/rs690.c:491:37:
warning: comparison of unsigned expression < 0 is always false
[-Wtautological-compare]
if (dfixed_trunc(priority_mark02) < 0)
dfixed_trunc is a macro:
drm_fixed.h:#define dfixed_trunc(A) ((A).full >> 12)
that returns the output of a shift right operation ... priority_mark02
is of type union fixed20_12, single element union of type u32, so I
can't see this check ever doing anything useful.
But, as always, I'm probably missing something obvious.
Sean
signature.asc
Description: This is a digitally signed message part
