On Mon, Nov 18, 2013 at 11:00:55PM +0100, Andreas Tobler wrote: > I prepared two patches, see below. The amd64 one is reviewed by bde@ and > the i386 is compile tested by me (runtime is theoretically also done, > but I'm not sure since I do not have 32-bit apps on my amd64). Use cc -m32.
> > The amd64 is compile and runtime tested. The tools, nm, shows that we > have the weak_references as before. > > If you agree I'd like to commit both within a few days to -CURRENT. If > someone steps up and confirms that the i386 part also runs, would be > great, but I expect it to work. > > If I'm correct, there is some similar work to be done on arm, mips and > sparc64, I'm happy to do this if the people like to have it done. But I > do not own either of them to test in native config. Except sparc64..... > Here I have blech ;) > > > Here the two patches > amd64: > http://people.freebsd.org/~andreast/weak_ref_amd64.diff > i386: > http://people.freebsd.org/~andreast/weak_ref_i386.diff Amd64 patch is fine. For i386, I do not see a definition of the WEAK_REFERENCE in the patch, and quick search of the pre-existing definition in sys/i386 or lib/libc/i386 does not reveal anything.
Description: PGP signature