On 06/18/14 23:13, John Baldwin wrote:
On Wednesday, June 18, 2014 4:36:24 pm Hans Petter Selasky wrote:
On 06/18/14 15:44, John Baldwin wrote:
On Wednesday, June 18, 2014 7:36:53 am Hans Petter Selasky wrote:

I'll probably put it into the tree next week.

I think having CTLFLAG_TUN do this by default is probably correct in the
long term.  The vast majority of places that use a tunable to prime a sysctl
are safe.  Why not do this for the initial patch:

- Add your change to auto-fetch values when CTLFLAG_TUN is set.
- Instead of adding a CTLFLAG_FETCH, add a CTLFLAG_NOFETCH to disable
- Make a pass over the existing places that use CTLFLAG_TUN seeing which
   ones are safe (so TUNABLE_* can just be removed), and which ones aren't
   (in which case add CTLFLAG_NOFETCH).

Followup changes can work on converting other places that don't currently
use CTLFLAG_TUN but have a SYSCTL + TUNABLE to use CTLFLAG_TUN instead as
well as fixing places that use CTLFLAG_NOFETCH to not need them.

I would suggest you commit some of the style changes (like using explicit
initializers in SYSCTL_OID()) as a separate change beforehand.



And updated patch:

freebsd-current@freebsd.org mailing list
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to