On Dec 5, 2014, at 16:52, jenkins-ad...@freebsd.org wrote: > See <https://jenkins.freebsd.org/job/Build-UFS-image/599/>
I’m not entirely sure why the "could not determine COMPILER_TYPE" error popped up, but I have a couple of questions/concerns related to the makefile snippet. 1. Does it make sense to check CC when running make install? 2. Why isn’t this value determined once in Makefile.inc1 (per build phase), then passed down from there (I’ve already considered the scenario where someone explicitly sets CC in a non-toplevel Makefile, which is a problem, but an outlier rather than the norm)? AFAICT, it gets recomputed for every recursive make, which contributes to useless forking for something that honestly doesn’t change all that often/at all. At EMC/Isilon at least, we set CC/CXX=false when running make distribute*/installkernel/installworld to catch logic errors with rebuilding code. Should this be in FreeBSD? Thanks! PS I filed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195732 to track this issue and resolve the problem.
Description: Message signed with OpenPGP using GPGMail