On Thu, May 28, 2015 at 12:09:35PM -0700, Craig Rodrigues wrote:
> On Thu, May 28, 2015 at 5:38 AM, Johannes Jost Meixner <x...@freebsd.org>
> wrote:
> > Hash: SHA256
> >
> > Hi Craig,
> >
> > I'll gladly help (good excuse to learn C), but looking at those errors
> > in general, one thing pops out:
> >
> > The warnings are almost all in contrib/ areas. Hence, any fix might
> > want to probably be submitted to upstream first.
> >
> Sure, if we can push fixes upstream that would be great.
> However, we shouldn't let that block us from comitting fixes to FreeBSD.
> The advantage of having code in the FreeBSD repo is that we can
> change it if we need to, even if the fix isn't yet in the upstream sources.
> Contrib code is not made out of stone that can't be modified!

If not upstreamed, there is a good chance it get lost during the next update. So
in the special case of warning fixes, I would strongly advice to upstream

Best regards,

Attachment: pgp0BlQSYtTQV.pgp
Description: PGP signature

Reply via email to