> On Aug 20, 2015, at 1:21 PM, Warner Losh <i...@bsdimp.com> wrote: > > >> On Aug 20, 2015, at 10:32 AM, Dimitry Andric <d...@freebsd.org> wrote: >> >> On 20 Aug 2015, at 18:24, Warner Losh <i...@bsdimp.com> wrote: >>> >>>> On Aug 20, 2015, at 9:38 AM, Oliver Pinter <oliver.pin...@hardenedbsd.org> >>>> wrote: >> ... >>> >>> I think you are wrong about the cause. -mno-avx is bogusly listed >>> unconditionally >>> in efi/Makefile.inc. I’m working on a patch now… >> >> Ah, this should be replaced with the recently introduced CFLAGS_NO_SIMD >> variable, then? > > Perhaps. Didn’t know this was a thing. That could use useful many places, > though > there were two clang specific args I needed to move, not just the one that’s > in this > flag. Maybe things are over-specified? > > Not sure I like bsd.cpu.mk growing more name-space pollution, especially > stuff that > isn’t documented somewhere (bsd.cpu.mk is included from sys.mk, which is > automaticallyed > globally included). All these hacks being stashed hither and yon are starting > to get > very hard to keep straight for someone who looks at this code every day, let > alone > somebody who invested CFLAGS_NO_SIMD independently for their code and finds > that breaks in an upgrade...
Ah, it doesn’t include -mno-aes, but luckily that’s understood by both. Not sure why that’s needed, but is that the same ‘class’ or no? Warner
Description: Message signed with OpenPGP using GPGMail