-----BEGIN PGP SIGNED MESSAGE-----
On 09/03/2015 18:30, David Wolfskill wrote:
> [Much trimming, both of older content and recipient addresses --
> On Thu, Sep 03, 2015 at 06:18:52PM -0400, Jung-uk Kim wrote:
>> ... AFAICT, the whole suspend/resume code looks incomplete and
>> very messy. In fact, I'll be very surprised if it ever worked.
>> Jung-uk Kim ...
> While I bow to your expertise in the area, I point out that I
> routinely suspend my laptop before putting it in my backpack, then
> cycling between the shuttle stop and my house during my daily
> commutes to & from work -- usually running stable/10, but I'm
> sometimes running head at the time.
> And I track both stable/10 and head daily on that laptop (in
> different slices).
> While I do encounter "issues" from time to time, those are rare
> enough that I'd call them "unusual." (To quantify that, I think
> I've had 3 - 5 such incidents since November 2014, while generally
> commuting 5 days/week.)
> I'll be happy to test. :-)
I am not saying the patch is wrong. Actually, it is in the right
direction. If you can, please test the following patch, too.
- --- sys/dev/drm2/radeon/radeon_drv.c (revision 287437)
+++ sys/dev/drm2/radeon/radeon_drv.c (working copy)
@@ -327,14 +327,14 @@ radeon_suspend(device_t kdev)
struct drm_device *dev;
+ ret = bus_generic_suspend(kdev);
+ if (ret)
+ return (ret);
dev = device_get_softc(kdev);
ret = radeon_suspend_kms(dev);
- - if (ret)
- - return (-ret);
- - ret = bus_generic_suspend(kdev);
- - return (ret);
+ return (-ret);
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
-----END PGP SIGNATURE-----
email@example.com mailing list
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"