FreeBSD_HEAD_amd64_gcc - Build #1761 - Fixed:

Build information:
Full change log:
Full build log:

Change summaries:

311974 by sobomax:
Fix slight type mismatch between so_options defined in sys/socketvar.h
and tw_so_options defined here which is supposed to be a copy of the
former (short vs u_short respectively).

Switch tw_so_options to be "signed short" to match the type of the field
it's inherited from.

311972 by ngie:
Add __BIT and __BITS macros from NetBSD to help support new testcases

MFC after:      1 week

311971 by mav:
Report random flash storage as non-rotating to GEOM_DISK.

While doing it, introduce respective constants in geom_disk.h.

MFC after:      1 week

311969 by ngie:
Remove __HAVE_LONG_DOUBLE #define from t_strtod.c and place it in Makefile

This is to enable support in other testcases

Inspired by lib/msun/tests/Makefile .

MFC after:      1 week

311968 by ngie:
Fix lib/libc/sys/access_test after r311925

sys/param.h needs to be #included in order for __FreeBSD_version to be checked

MFC after:      13 days

311964 by cem:
g_raid: Prevent tasters from attempting excessively large reads

Some g_raid tasters attempt metadata reads in multiples of the provider
sectorsize.  Reads larger than MAXPHYS are invalid, so detect and abort
in such situations.

Spiritually similar to r217305 / PR 147851.

PR:             214721
Sponsored by:   Dell EMC Isilon

311963 by rpokala:
Remove writability requirement for single-mbuf, contiguous-range

m_pulldown() only needs to determine if a mbuf is writable if it is going to
copy data into the data region of an existing mbuf. It does this to create a
contiguous data region in a single mbuf from multiple mbufs in the chain. If
the requested memory region is already contiguous and nothing needs to
change, the mbuf does not need to be writeable.

Submitted by:   Brian Mueller <>
Reviewed by:    bz
MFC after:      1 week
Sponsored by:   Panasas
Differential Revision:

311962 by arybchik:
sfxge(4): stats refresh in SW should depend on HW update period

The period should be taken into account by the function which
refreshes driver stats.

Reviewed by:    philip
Sponsored by:   Solarflare Communications, Inc.
MFC after:      2 days
Differential Revision:

311961 by arybchik:
sfxge(4): do not ignore requested MAC stats update period

Firmware version which takes PERIOD_MS parameter into account is

Reviewed by:    philip
Sponsored by:   Solarflare Communications, Inc.
MFC after:      2 days
Differential Revision:

311958 by scottl:
Print out the number of queues/MSIx vectors.

Sponsored by:   Netflix

311954 by ian:
Rework tty_drain() to poll the hardware for completion, and restore
drain timeout handling to historical freebsd behavior.

The primary reason for these changes is the need to have tty_drain() call
ttydevsw_busy() at some reasonable sub-second rate, to poll hardware that
doesn't signal an interrupt when the transmit shift register becomes empty
(which includes virtually all USB serial hardware).  Such hardware hangs
in a ttyout wait, because it never gets an opportunity to trigger a wakeup
from the sleep in tty_drain() by calling ttydisc_getc() again, after
handing the last of the buffered data to the hardware.

While researching the history of changes to tty_drain() I stumbled across
some email describing the historical BSD behavior of tcdrain() and close()
on serial ports, and the ability of comcontrol(1) to control timeout
behavior.  Using that and some advice from Bruce Evans as a guide, I've
put together these changes to implement the hardware polling and restore
the historical timeout behaviors...

 - tty_drain() now calls ttydevsw_busy() in a loop at 10 Hz to accomodate
   hardware that requires polling for busy state.

 - The "new historical" behavior for draining during close(2) is retained:
   the drain timeout is "1 second without making any progress".  When the
   1-second timeout expires, if the count of bytes remaining in the tty
   layer buffer is smaller than last time, the timeout is extended for
   another second.  Unfortunately, the same logic cannot be extended all
   the way down to the hardware, because the interface to that layer is a
   simple busy/not-busy indication.

 - Due to the previous point, an application that needs a guarantee that
   all data has been transmitted must use TIOCDRAIN/tcdrain(3) before
   calling close(2).

 - The historical behavior of honoring the drainwait setting for TIOCDRAIN
   (used by tcdrain(3)) is restored.

 - The historical kern.drainwait sysctl to control the global default
   drainwait time is restored, but is now named kern.tty_drainwait.

 - The historical default drainwait timeout of 300 seconds is restored.

 - Handling of TIOCGDRAINWAIT and TIOCSDRAINWAIT ioctls is restored
   (this also makes the comcontrol(1) drainwait verb work again).

 - Manpages are updated to document these behaviors.

Reviewed by:    bde (prior version)

311953 by cem:
pciconf(8): Reallow trailing colon in selectors

Reallow device selectors to have a trailing colon, as documented in the
manual page.  This was broken along with some unrelated cleanups in

PR:             215979
Reported by:    David Boyd <David.Boyd49 at>
Sponsored by:   Dell EMC Isilon

311952 by markj:
Enable the use of ^C and ^S/^Q in DDB.

This lets one interrupt DDB's output, which is useful if paging is
disabled and the output device is slow.

Submitted by:   Anton Rang <>
Reviewed by:    jhb
MFC after:      1 week
Differential Revision:

311951 by ian:
Include sys/systm.h for use of bootverbose. Fixes powerpc MPC85XXSPE build.

311950 by bz:
Get rid of a compiler warning which I saw too often.
Include netinet/in.h before ip_compat.t which will then check if
IPPROTO_IPIP is defined or not.  Doing it the other way round,
ip_compat.h would not find it defined and netinet/in.h then
redefine it.

311949 by np:
cxgbe/tom: Add VIMAGE support to the TOE driver.

Active Open:
- Save the socket's vnet at the time of the active open (t4_connect) and
  switch to it when processing the reply (do_act_open_rpl or

Passive Open:
- Save the listening socket's vnet in the driver's listen_ctx and switch
  to it when processing incoming SYNs for the socket.
- Reject SYNs that arrive on an ifnet that's not in the same vnet as the
  listening socket.

CLIP (Compressed Local IPv6) table:
- Add only those IPv6 addresses to the CLIP that are in a vnet
  associated with one of the card's ifnets.

- Set vnet from the toepcb when processing TCP state transitions.
- The kernel sets the vnet when calling the driver's output routine
  so t4_push_frames runs in proper vnet context already.  One exception
  is when incoming credits trigger tx within the driver's ithread.  Set
  the vnet explicitly in do_fw4_ack for that case.

MFC after:      3 days
Sponsored by:   Chelsio Communications

311948 by avos:
rtwn: fix R92C_TXDW4_RTSRATE_M definition (0x3f -> 0x1f)

Submitted by:   kevlo

311947 by pfg:
rpcgen(1): Avoid unused variable warning on generated code.

Avoid "unused variable 'i'" warnings in generated .c files by only
emitting the "int i;" for non-opaque arrays. Opaque arrays use
xdr_opaque() rather than iterating over the array.

Obtained from:  OpenBSD (CVS rev 1.28)
MFC after:      1 week

311946 by emaste:
readelf: add S390 relocation types


Reviewed by:    bz
MFC after:      1 month
Sponsored by:   The FreeBSD Foundation
Differential Revision:

311945 by cperciva:
Remove obsolete path from fortune(6).  This was inadvertantly left over
when fortune and other games moved from /usr/games to /usr/bin; I am
removing rather than correcting it since we normally do not mention in
the FILES section the paths to programs in /usr/bin/.

PR:             215962
Reported by:    Andras Farkas

311942 by emaste:
readelf: add more PPC64 relocation types found in LLVM

MFC after:      2 weeks
MFC with:       r311941
Sponsored by:   The FreeBSD Foundation

311941 by emaste:
readelf: add PPC64 relocation types

Reported by:    Mark Millard
MFC after:      2 weeks
Sponsored by:   The FreeBSD Foundation
Differential Revision:

311935 by mav:
Pretend we support some IOCTLs to not scary upper layers.

MFC after:      2 weeks

311933 by dim:
Use proper prototypes in struct boot_module_t

With clang 4.0.0, we are getting the following warnings about struct
boot_module_t in efi's boot_module.h:

In file included from sys/boot/efi/boot1/ufs_module.c:41:
sys/boot/efi/boot1/boot_module.h:67:14: error: this function declaration is not 
a prototype [-Werror,-Wstrict-prototypes]
        void (*init)();
sys/boot/efi/boot1/boot_module.h:92:16: error: this function declaration is not 
a prototype [-Werror,-Wstrict-prototypes]
        void (*status)();
sys/boot/efi/boot1/boot_module.h:95:24: error: this function declaration is not 
a prototype [-Werror,-Wstrict-prototypes]
        dev_info_t *(*devices)();
3 errors generated.

Fix this by adding 'void' to the parameter lists.  No functional change.

Reviewed by:    emaste, imp, smh
MFC after:      3 days
Differential Revision:

311932 by dim:
Make EFI_RESERVED_SERVICE a proper prototype

With clang 4.0.0, the EFI API header causes the following warning:

In file included from sys/boot/efi/loader/bootinfo.c:43:
In file included from sys/boot/efi/loader/../include/efi.h:52:
sys/boot/efi/include/efiapi.h:534:32: error: this function declaration is not a 
prototype [-Werror,-Wstrict-prototypes]

Add VOID to make it into a real prototype.

Reviewed by:    imp, emaste, tsoome
MFC after:      3 days
Differential Revision:

311931 by sbruno:
Restore v6 offload caps for igb(4) class devices.

Reported by:    tuxen

311930 by dumbbell: Add myself

Approved by:    antoine (mentor)
Differential Revision:

311929 by dim:
Don't include <errno.h> in reloc_elf.c, as it includes <stand.h> just
after it, which has a conflicting definition of errno.  This leads to
the following warning with clang 4.0.0:

    In file included from sys/boot/common/reloc_elf32.c:6:
    In file included from sys/boot/common/reloc_elf.c:37:
    /usr/obj/usr/src/tmp/usr/include/stand.h:155:12: error: this function 
declaration is not a prototype [-Werror,-Wstrict-prototypes]
    extern int errno;
    sys/sys/errno.h:46:26: note: expanded from macro 'errno'
    #define errno           (* __error())

MFC after:      3 days

311928 by asomers:
Fix build of usr.bin/tail with GCC

Submitted by:   pluknet
Reported by:    pluknet
MFC after:      27 days
X-MFC-with:     311895
Sponsored by:   Spectra Logic Corp

_______________________________________________ mailing list
To unsubscribe, send any mail to ""

Reply via email to