On 2017-04-28 17:42, Andriy Gapon wrote:
On 28/04/2017 14:56, Michael Jung wrote:
I have mad the requested change..

[root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]# diff zio.c
~mikej/zio.c.orig
965c965
<         size, NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW,
---
BP_GET_PSIZE(bp), NULL, NULL, ZIO_TYPE_FREE, ZIO_PRIORITY_NOW,

Yes, that's the change that I had in mind.
I was a little bit confused by the order of the original and modified files,
though :-)

[root@bsd11 /usr/src/sys/cddl/contrib/opensolaris/uts/common/fs/zfs]#

As to the pool size:

[root@bsd11 /usr/home/mikej]# zpool list
NAME SIZE ALLOC FREE EXPANDSZ FRAG CAP DEDUP HEALTH ALTROOT
tank   199G   143G  55.9G         -    85%    71%  1.00x  ONLINE  -
[root@bsd11 /usr/home/mikej]#

I should have also mentioned that besides poudriere running a build, it was removing old logs - There was some 43G of old logs files that were in the process
of being removed.

So, given that the panic was in the freeing path, you were probably low on the pool space back when those log files were created. I mean that the gang blocks
are typically created when a pool is very fragmented.

I will hammer the box with and report back first of the week whether the panic
re-occurs or not.

Please also try removing those old files again too.
Running zpool scrub afterwards could be a good idea too.

Thank you again!

Andriy:

I am happy to report that the system no longer panics. As requested I removed the remaining logs (34G worth) and punished the file system as hard as I could.

A scrub of the pool completed without error

Will the change be committed or do I need to open a PR?

Please let me know if I can supply additional information or if there are any
further tests you would like me to perform.

Thanks again for you prompt reply and apparent solution.

Regards,

Michael Jung
_______________________________________________
freebsd-current@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-current-unsubscr...@freebsd.org"

Reply via email to