On Fri, Jun 02, 2017 at 10:45:16AM +0300, Konstantin Belousov wrote: > I implemented an option to specify absolute time for kqueue(2) timers, > and did required type changes to support larger values in struct kevent. > Please see https://reviews.freebsd.org/D11025 for the patch, including > man page update, and for some more detailed explanation. > > Please review.
For me that looks good. As one of those requesting for that change (actually proxying the request from glib people for a appel's kqueue64 compatible interface). I find this approach more clever. As far as I remember it perfectly fits glib folks requirements (unfortunatly I could not reach out any of them to review yet) Here is a mail describing their requirement at the time: https://lists.freebsd.org/pipermail/freebsd-hackers/2014-March/044451.html In any case it opens the doors to be able to use kevent based timers with a nanonsecond precision useful, so looks good to me. Thank you, Best regards, Bapt
Description: PGP signature