Warner Losh wrote:
> On Mon, Dec 3, 2018 at 8:10 AM Warner Losh <i...@bsdimp.com> wrote:
> 
>>
>> On Mon, Dec 3, 2018 at 12:24 AM Baptiste Daroussin <b...@freebsd.org>
>> wrote:
>>
>>> On Sun, Dec 02, 2018 at 06:08:34PM +0300, Yuri Pankov wrote:
>>>> Hi,
>>>>
>>>> Building disc1.iso using `make release` and having WITH_CTF set in
>>>> src.conf leads to "File too big" displayed when booting the image.
>>>>
>>>> Would it make sense to build loader and related parts without CTF
>>>> unconditionally as it doesn't look useful there?
>>>>
>>>
>>> Fully agree with you
>>>
>>
>> What a great Idea. We already turn it off in defs.mk:

Sorry about that, I incorrectly assumed it wasn't done yet as there was
a difference for me.

>> MK_CTF=         no
>>
>> which should be global to every single Makefile under stand. I'm not sure
>> why that's turning it back on.
>>
> 
> % cat /etc/src.conf
> WITH_CTF=yes
> FRED=present
> % cd stand/cdboot
> % make -V MK_CTF
> no
> % make -V FRED
> present
> %
> 
> So this sure sounds like a false positive to me. Do you have logs showing
> cdboot building with MK_CTF=yes?

Diff'ing the log for src/stand w/o and with -DWITH_CTF shows a lot of
ctfconvert calls in the latter case.  Attached is the diff of binary
sizes in obj/ for stand/i386; could one of those be the problem I'm seeing?
--- siz1        2018-12-03 18:49:01.764091000 +0300
+++ siz2        2018-12-03 18:49:39.666198000 +0300
@@ -22,28 +22,28 @@
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/isoboot/isoboot     14395
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/isoboot/isoboot.8.gz        
1324
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/isoboot/isoboot.bin 12553
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/libi386/libi386.a   318926
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/libi386/libi386.a   358146
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader/.depend      213
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader/vers.c       99
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/.depend  212
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th       
380928
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th.bin   
369808
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th.sym   
1213320
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th       
598016
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th.bin   
584344
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/loader_4th.sym   
1427856
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_4th/vers.c   99
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/.depend  213
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua       
434176
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua.bin   
422992
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua.sym   
1508144
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua       
716800
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua.bin   
706132
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/loader_lua.sym   
1791284
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_lua/vers.c   99
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/.depend 150
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp     
319488
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp.bin 
308304
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp.sym 
991168
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp     
495616
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp.bin 
484536
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/loader_simp.sym 
1167400
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/loader_simp/vers.c  99
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/mbr/mbr     512
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pmbr/pmbr   512
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/loader       434176
-/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/pxeboot      436224
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/loader       716800
+/usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/pxeboot      718848
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/pxeboot.8.gz 2311
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/pxeldr/pxeldr       512
 /usr/obj/home/yuripv/ws/ctf/amd64.amd64/stand/i386/zfsboot/zfsboot     262656

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to