<<On Sun, 27 Aug 2000 14:25:55 -0700 (PDT), Archie Cobbs <[EMAIL PROTECTED]> said:

> However, many routines that take an mbuf parameter assume that the
> mbuf given to them is modifiable and proceed to write all over it.

s/assume/require as a necessary precondition/

It's not a coding error, it's part of the specification.  No, it's not
documented -- but it's pretty clear from the design of the original

>   3.  For any routines that do need to modify mbuf data, but don't
>       assume anything about the mbuf, alter those routines to do
>       an m_pullup() when necessary to make the data are they are
>       working on modifiable.

m_pullup is evil.  It would be better to fix the places (i.e.,
ip_input and ip_output) which make the modification necessary.


Garrett A. Wollman   | O Siem / We are all family / O Siem / We're all the same
[EMAIL PROTECTED]  | O Siem / The fires of freedom 
Opinions not those of| Dance in the burning flame
MIT, LCS, CRS, or NSA|                     - Susan Aglukark and Chad Irschick

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to