:
:Matt Dillon <[EMAIL PROTECTED]> writes:
:>     I think the only real solution is to rip out the externally visible
:>     zalloc/zfree inlines and replace them with real routines.  I will happily
:>     do this, those inlines have always been an eyesore to me and the
:>     performance benefit is minimal at best.  That will solve the SMP and
:>     INVARIENTS mixing problem (at least for zalloc/zfree).
:
:Just make them always call zalloci() and zfreei().
:
:/assar
    
    I don't think that's good enough.  At the moment the API for non-interrupt
    operation is zalloc() and zfree(), and zalloci() and zfreei() are
    supposed to be called from interrupts.    If we intend to keep both
    families (zalloc() and zalloci()), then both families have to work
    properly.  If we intend to remove one family (i.e. remove the zalloc()
    family), then we have to physically remove the calls from the codebase
    to prevent anyone from accidently calling them from an SMP build.

    We can't just go do an end-run around the established API as a hack around
    the problem.

                                                -Matt



To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to