On Sun, 2 Sep 2001, Alfred Perlstein wrote:

> * John Polstra <[EMAIL PROTECTED]> [010902 20:23] wrote:
> > In article <[EMAIL PROTECTED]>,
> > Gersh  <[EMAIL PROTECTED]> wrote:
> > > sys/malloc.h says that the macro versions of MALLOC/FREE are
> > > deprecated however they are used all over the place.  I belive that they
> > > are cluttering and dont really have a purpose.  Does anybody else agree?

Yes (I wrote the line that says they are deprecated).

> > > If I were to make up a patch for current removing all of them would
> > > anybody care enough to commit it (Or care enough to not have it commited)


> > Please don't.  It would just create a bunch of new gratuitous
> > differences against the other BSDs.

At least in old code.

> The reason for the macro is that when the size paramter is a constant
> there's an evil trick that makes selecting the malloc bucket really
> cheap.

That's not the reason.  The size parameter is not constant since MALLOC()
just calls malloc().  I wouldn't call the big conditional statement in
BUCKETINDX() an evil trick.  But perhaps it should be replaced by fls().
A builtin fls() could handle constants just as well.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to