On Tue, 4 Sep 2001, Maxim Sobolev wrote:

> > [neither Maxim Sobolev nor Brent Verner wrote]
> > In message <[EMAIL PROTECTED]>, Brent Verner writes:
> > >#include <newbie_kernel_hacker_warning.h>
> > >
> > >I've done a /cursory/ look over how this v_tag is used.  I'm not sure
> > >this is a simple/clean as you propose, since this is used in the
> > >IS_LOCKING_VFS macro, as well as in union_subr.c...
> >
> > Well, that is just too bad, because IS_LOCKING_VFS is wrong then.
> >
> > The places which inspect v_tag will have to be changed to use
> > strcmp() then...
> I think that we can add a new vnode flag, say VCANLOCK, so that each
> particular VFS can set it if it supports locking, which should allow
> to remove pre-defined VFS list from the IS_LOCKING_VFS macro. I can
> produce a patch if it sounds reasonably.

Since IS_LOCKING_VFS() is a temporary kludge, the correct fix is to remove
it (after fixing whatever it was for), not to add more cruft.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to