Apparently, On Mon, Feb 18, 2002 at 11:51:44AM -0800,
        Matthew Dillon said words to the effect of;

> :I request that you give say a 3 day review period for this.
> :I know JHB still has limited email access (no DSL yet).
> :This may be something he should review.

I second this request.

>     Sigh.  Are you intending to ask me to have JHB review every single change
>     I make to -current?

For changes to the mutex code, yes.

> Because if you are the answer is:  "Are you out of
>     your mind?".


>     I'm fairly sure JHB does not have a patch to address this but, please,
>     be my guest and check P4.

Actually he does.  Maybe you should have checked p4 first yourself.

What John's patch does is spin while the lock owner is running on another cpu.
Spinning while there are no other processes on the run queues as well makes sense
but you'll also be doing a lot of acquires and releases of sched_lock.

The only thing that jumped out at me looking at the patch is that critnest cannot
be 0 here because the sched_lock is held; holding a spin lock implies being in a
critical section.  I need to think about this more and would like you to wait until
John has a chance to look at it as well.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to