On Sat, May 11, 2002 at 04:00:53PM +0300, Maxim Sobolev wrote: > KOMATSU Shinichiro wrote: > > > > (add To: [EMAIL PROTECTED]) > > > > From: Garrett Rooney <[EMAIL PROTECTED]> > > Subject: Re: Who broke 'make clean' for ports ? > > Date: Sat, May 11, 2002 at 02:31:32AM JST > > > > > there's a circular dependency that was just introduced to gettext. > > > gettext now depends on expat, which depends on gmake, which depends on > > > gettext. > > > > Recently, I wrote a patch for bsd.port.mk that checks circular dependency. > > If a dependency loop is found, it gives you a warning and > > does not invoke 'make' process any further. > > > > Someone, please test the patch below. > > If no problem is found, I will send-pr(8). > > I don't think that we really need such patch. In 99.9999% of cases it > would just waste CPU cycles. Circular dependency is a bug and as such > it doesn't need to be a supported "special case".
Actually it would be useful to have this functionality somewhere. I recently spent a couple of hours trying to track down a circular dependency I had introduced via a bsd.port.mk patch. The main symptom was that the make_index script would just go into a loop and exhaust memory. I ended up finding it by adding all sorts of debugging printfs to the perl script, but this was pretty ugly. Kris
Description: PGP signature