On Sat, Aug 10, 2002 at 03:59:42PM +0200, Morten Rodal wrote:
> On Sat, Aug 10, 2002 at 02:02:39PM +0200, Eirik Nygaard wrote:
> > I have just rewritten the rmuser perl script to C, it would be 
> > great if you could take a look at it and check if everything is ok.
> 
> You should probably replace the strcpy() and strcat() with strlcpy(3) and
> strlcat(3), or at least use the strncpy(3) and strncat(3). Also, sprintf()
> should be replaced with snprintf(3).
> 
> Maybe close the file descriptors in the signal handlers?

 Also, please clean it up, style-wise.  I couldn't even read it due to
 mis-aligned braces ( { and } ).  Thanks.

-- 
Bosko Milekic * [EMAIL PROTECTED] * [EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to