On Fri, 6 Sep 2002, Bruce A. Mah wrote:

> If memory serves me right, Poul-Henning Kamp wrote:
> > Good catch.
> >
> > I'm surprised the compiler doesn't whine.
> Thanks, and "me too".

Warnings are mostly turned off for not unimportant places like libraries
since these places are too poorly written to compile without warnings.

> PS.  Actually I'm surprised that nobody caught the problem in the past
> five months...this bug prevented release builds from 5-CURRENT hosts.
> Maybe I'm the only person crazy enough to try this.  :-)

This bug was caught in PR 42384.  The fix in the PR is not so good.

libmd is also broken for some cases involving pipes.  IIRC, this is
caused by the bogus st_size checks in the same function.  st_size is
only valid for regular files.

The loop in the function fails to to terminate if read() returns 0,
which can probably happen if the file shrinks underneath us.


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to