I got a crash today because "xvp" did not have an interlock when the
call was made to vn_lock(LK_INTERLOCK):
407                     if (snapdebug)
408                             vprint("ffs_snapshot: busy vnode", xvp);
409                     if (vn_lock(xvp, LK_EXCLUSIVE | LK_INTERLOCK, td) != 0)
410                             goto loop;
411                     xp = VTOI(xvp);
412

I don't in fact see any reason why "xvp" would have been locked already
and that this could possibly be valid in the face of a mountpoint which
had any vnodes at all open.  This occurred on fscking my "/tmp"
filesystem because of crashes (due to an SSE utilization bug in the
kernel, it seems), which I'm sure was a filesystem in heavy use already.

Does anyone have any insight on what the correct fix to this is?  I
don't have any idea exactly how to correct the locking in this function.
Thanks for insight!

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to