In message <[EMAIL PROTECTED]>, Nate Lawson wri
tes:

>> I could agree to make g_dev_ioctl fail the ioctl with some errno
>> if they came back as zero, but not substituting another value.
>
>The attached patch makes everything work fine for my drive (64 MB USB
>flash).

Apart from the choice of EINVAL, this would be OK with me, I would
probably say ENOENT instead.  EINVAL generally means "you gave a
wrong parameter to a syscall",  ENOENT is more of a "Looked, found
nothing" kind of error.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED]         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message

Reply via email to