* M. Warner Losh <[EMAIL PROTECTED]> [030209 08:39] wrote: > In message: <[EMAIL PROTECTED]> > Alfred Perlstein <[EMAIL PROTECTED]> writes: > : syslog(3) botches things if you pass it a string that has "%%m" in it. > : this should fix it, any comments? > : > > With the above fix, "fred %%m" will produce > 'fred %%ERRNO-ERROR-MESSAGE' would it not? Isn't there one too many > fputc(ch, fmt_fp) in the case where you detect %%? > > + ++fmt; > + fputc(ch, fmt_fp); > > instead in the '%%' if statement. This would print only one '%' ala > printf.
Heh, the format string is passed through printf later, we don't want to eat the extra % otherwise it will cause problems for us. -- -Alfred Perlstein [[EMAIL PROTECTED]] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' To Unsubscribe: send mail to [EMAIL PROTECTED] with "unsubscribe freebsd-current" in the body of the message