Dear Poul-Henning,
i think the following is not correct
RCS file: /home/ncvs/src/sys/netgraph/ng_device.c,v
retrieving revision 1.2
diff -u -r1.2 ng_device.c
--- netgraph/ng_device.c 2 Feb 2003 13:30:00 -0000 1.2
+++ netgraph/ng_device.c 2 Mar 2003 19:48:38 -0000
@@ -66,7 +66,7 @@
/* Netgraph type */
static struct ng_type typestruct = {
NG_ABI_VERSION, /* version */
- NG_DEVICE_NODE_TYPE, /* name */
+ .d_name = NG_DEVICE_NODE_TYPE,
ng_device_mod_event, /* modevent */
ng_device_cons, /* constructor */
ng_device_rcvmsg, /* receive msg */
@@ -114,19 +114,14 @@
please fix
thanks
max
-----Original Message-----
From: Poul-Henning Kamp [mailto:[EMAIL PROTECTED]
Sent: Sun 3/2/2003 12:26 PM
To: Marcel Moolenaar
Cc: [EMAIL PROTECTED]
Subject: Re: HEADSUP: Driver mega-commit ahead.
In message <[EMAIL PROTECTED]>, Marcel Moolenaar writes
:
>On Sun, Mar 02, 2003 at 09:14:13PM +0100, Poul-Henning Kamp wrote:
>>
>> I plan to commit
>> http://phk.freebsd.dk/patch/cdevsw.patch
>> one of the first days of the week.
>>
>> Basically, it changes cdevsw initializations to use C99 sparse
>> format, and thereby eliminates 859 lines of redundant defaultvalue
>> initializations.
>
>I thought HEAD was in a slush mode. des' sweep and this sweep seems
>like the kind of changes we don't want at this time. Has this changed
>or did re@ approve it (both cases)?
I can't talk for DES sweep, (although I'll say that it seems like
a step in the right direction for me).
This particular sweep gives os much better cross-branch source
portability and therefore I think it is exactly the kind of thing
we want before the RELENG_5 branch.
--
Poul-Henning Kamp | UNIX since Zilog Zeus 3.20
[EMAIL PROTECTED] | TCP/IP since RFC 956
FreeBSD committer | BSD since 4.3-tahoe
Never attribute to malice what can adequately be explained by incompetence.
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-current" in the body of the message
