https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292138
Bug ID: 292138
Summary: graphics/colord: rename and disable completion option
Product: Ports & Packages
Version: Latest
Hardware: Any
OS: Any
Status: New
Severity: Affects Some People
Priority: ---
Component: Individual Port(s)
Assignee: [email protected]
Reporter: [email protected]
Flags: maintainer-feedback?([email protected])
Assignee: [email protected]
I have a few problems with this option:
1. Upstream calls it "bash_completion", so it is bash and bash only
2. The port calls it:
> COMPLETION_DESC=Build and install shell completions
but should
> BASH_COMPLETION_DESC=Build and install bash completion
Thus the option should be BASH_COMPLETION
3. This option should be disabled by default bacause:
* It pulls shells/bash-completion which pulls
bash-completion-zfs/bash-completion-freebsd and bash + readline itself.
* bash is not the default shell and might not even be installed in the system
* colord works w/o it as well, especially as a transitive dependency
> grep -r --include=Makefile* COMPLETION .
Gives me quite some ports which have completion and only two depend on
shells/bash-completion:
$ grep -r --include=Makefile* COMPLETION . | grep shells/bash-completion
> ./graphics/colord/Makefile:COMPLETION_BUILD_DEPENDS=
> bash-completion>=2.0:shells/bash-completion
> ./net/onedrive/Makefile:COMPLETION_BUILD_DEPENDS=
> bash-completion>0:shells/bash-completion
> ./net/onedrive/Makefile:COMPLETION_RUN_DEPENDS=
> bash-completion>0:shells/bash-completion
I think it would be fine as well to keep it as default as long as it won't
depend on shells/bash-completion.
I'd be happy to provide a patch!
--
You are receiving this mail because:
You are the assignee for the bug.
