On Fri, Apr 29, 2011 at 08:41:11AM +0300, Andriy Gapon wrote:
>
> There is another thing that I've just noticed - wouldn't the port overwrite a
> custom pcm-oss.conf (if any)?
>
That is true... I guess I didn't stumble across this because I
edited the /compat/linux/etc/asound.conf similar to the one below
/usr/local/etc instead of editing the pcm-oss.conf this port installs.
> I think it would be nice to do the usual .conf-dist vs .conf dance here.
> E.g. something like:
> CONF_FILE= etc/alsa/pcm/pcm-oss.conf
>
> post-patch:
> @${RM} ${WRKDIR}/${CONF_FILE}.orig
> @${MV} ${WRKDIR}/${CONF_FILE} ${WRKDIR}/${CONF_FILE}-dist
>
> post-install:
> @if [ ! -f ${PREFIX}/${CONF_FILE} ]; then \
> ${CP} -p ${PREFIX}/${CONF_FILE}-dist ${PREFIX}/${CONF_FILE} ; \
> fi
> PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} POST-INSTALL
>
>
> And in pkg-plist:
> @unexec if cmp -s %D/etc/alsa/pcm/pcm-oss.conf-dist
> %D/etc/alsa/pcm/pcm-oss.conf; then rm -f %D/etc/alsa/pcm/pcm-oss.conf; fi
> etc/alsa/pcm/pcm-oss.conf-dist
> @exec if [ ! -f %D/etc/alsa/pcm/pcm-oss.conf ] ; then cp -p %D/%F
> %B/client.conf; fi
>
>
> What do you think?
I think now that the port is committed it's the maintainer's call,
so I Cc'd him. :)
Thanx,
Juergen
_______________________________________________
[email protected] mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-emulation
To unsubscribe, send any mail to "[email protected]"
