On Apr 13, 2012, at 9:13 PM, Grzegorz Bernacki wrote: Hi Gregorz,
It was good to finally meet you! >>> o In sbin/Makefile: we should have a distinct MK_NANDFS option >>> for use by the file system code. > > - Is a separate MK_NANDFS knob really needed? Other filesystems don't seem to > follow this route > - The sys/fs/nandfs is only included per kernel config option, other userspace > components per MK_NAND > - Do you really think it is useful to have NAND framework built without NANDFS > and vice versa, the FS without userland tools for it? I don't think it's *really* needed per se, but since nandfs is a useful file system on any kind of storage media, I can see that people may want the file system, but not the NAND framework bits. I thought that keeping the distinction between the 2 (as we do in the kernel with "options NANDFS" and "device nand") is probably a good thing. I leave it up to you. It's not of any real significance either way... Thanks for taking care of all the review comments! Cheers, -- Marcel Moolenaar [email protected] _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-geom To unsubscribe, send any mail to "[email protected]"
