Re: Linux ioctl not implemented error

[Marcel Moolenaar]

Alfred Perlstein wrote:
> 
> > +     if (!error) {
> > +         lvol = *lvolp;
> > +         lvol.channel0 = bsd_vol.vol[0];
> > +         lvol.channel1 = bsd_vol.vol[1];
> > +         lvol.channel2 = bsd_vol.vol[2];
> > +         lvol.channel3 = bsd_vol.vol[3];
> 
> FYI the kernel structures are completely identical, you don't really
> gain anything by doing this convertion.  Should this be put in for
> clarity?  I'm not sure.

No. When it's there, you automaticly assume it's there for a reason.
Since the structures are identical, there's no reason for the code to be
there. Very confusing :-)

-- 
Marcel Moolenaar                        mailto:[EMAIL PROTECTED]
SCC Internetworking & Databases           http://www.scc.nl/
The FreeBSD project                mailto:[EMAIL PROTECTED]


To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message