I haven't finished looking at the whole thing yet, but I see one
immediate (trivial to fix) problem:
+ BUF_LOCK(holdbp, LK_EXCLUSIVE))
I would recommend getting a *NON* blocking lock, and bumping your gap
mechanism if you can't get the lock (and not store the buffer). Otherwise
you may create a deadlock situation elsewhere.
-
Alred, in your followup email you said something about the existing
clustering being broken. It seems to work for me (64KB clustering), could
you give me an example? NFS clustering is based very heavily only VFS
clustering. If you aren't seeing NFS clustering for commit messages then
perhaps VFS clustering got broken somehow...
-Matt
:I've been trying to workout mega-clusters for NFS, since afaik the
:vfs_cluster code will only do 64k chunks and we can benifit greatly
:by compacting ranges for commit RPCs.
:...
:
:Index: nfs_bio.c
:===================================================================
:RCS file: /home/ncvs/src/sys/nfs/nfs_bio.c,v
:retrieving revision 1.80
:...
To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message
