Re: Doh, compiler bug... (was Re: possible bug in kernel/if_ether.c)

[Daniel C. Sobral]

Matthew Dillon wrote:
> 
>     I found it.  The code itself is broken.  I missed the lack of parens.
> 
>                 if (m->m_len < sizeof(struct arphdr) &&
>                     (m = m_pullup(m, sizeof(struct arphdr)) == NULL)) {
>                         log(LOG_ERR, "arp: runt packet -- m_pullup failed.");
>                         continue;
> 
>     Should be:
> 
>                 if (m->m_len < sizeof(struct arphdr) &&
>                     ((m = m_pullup(m, sizeof(struct arphdr))) == NULL)) {
>                         log(LOG_ERR, "arp: runt packet -- m_pullup failed.");
>                         continue;
> 
>     I'm committing the fix now.

Funny. The parenthesis was the FIRST thing I noticed. I just assumed I
was remembering the priorities wrong...

--
Daniel C. Sobral                        (8-DCS)
[EMAIL PROTECTED]
[EMAIL PROTECTED]
[EMAIL PROTECTED]

        One Unix to rule them all, One Resolver to find them,
        One IP to bring them all and in the zone bind them.




To Unsubscribe: send mail to [EMAIL PROTECTED]
with "unsubscribe freebsd-hackers" in the body of the message