On Tue, Jul 5, 2011 at 6:36 AM, Robert Millan <[email protected]> wrote: > 2011/7/5 Dimitry Andric <[email protected]>: >> As far as I can see, this code only gives warnings when compiled with >> gcc 4.5 or higher, and when using the -Wundef flag. Isn't it easier to >> just remove the -Wundef flag here? > > Here's a patch to remove -Wundef. I think it's a bad idea however, > IMHO it's better to fix the cause of the warning instead.
The problem is that, IIRC, C guarantees that an undefined symbol when checked in a #if context will evaluate to 0. So -Wundef checks for warnings on compliant code. Personally I have no objection to the original patch. Cheers, matthew _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-hackers To unsubscribe, send any mail to "[email protected]"
